fix otlp/json exporter #1882
Merged
fix otlp/json exporter #1882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Moving to draft to add changelog and enable integration test. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1882 +/- ##
=======================================
- Coverage 74.6% 74.6% -0.1%
=======================================
Files 122 122
Lines 19952 19952
=======================================
- Hits 14902 14901 -1
- Misses 5050 5051 +1 ☔ View full report in Codecov by Sentry. |
ok, I will create a separate PR for adding this to the integration test, it's a slightly bigger effort. We already have the unit test to validate the fix. Also added the changelog. |
TommyCpp
approved these changes
Jun 15, 2024
|
merging, will incorporate any new comments in a separate PR. |
This was referenced Jun 18, 2024
Closed
Closed
Closed
ramgdev
pushed a commit
to ramgdev/opentelemetry-rust
that referenced
this pull request
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1763
Changes
As discussed here, the unit-test are contributed by @hwrdtm
Please provide a brief description of the changes here.
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes